[
https://issues.apache.org/jira/browse/MNG-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825014#comment-17825014
]
ASF GitHub Bot commented on MNG-8072:
-------------------------------------
rmannibucau commented on PR #1437:
URL: https://github.com/apache/maven/pull/1437#issuecomment-1987157849
> there is no way for a plugin to participate as part of the mojo-execution
Yes, this is why I mentionned we can need to revisit a but the current API.
Once again my main concern was that the "consumerPom" API has no link with
consumer pom at all and we must converge to maven 4 (even if we backport to
3.9) cause otherwise your API will be dead, even in 3.x when we'll backport
things.
Ultimately it looks more - in v3 world - to attached artifacts so it is
doable without the new API to me - short term.
Long term we need to find a better lifecycle but can need some list
discussion?
> It won't break anything ... plugins not supporting this will simply never
set this and then getConsumerPom() will return the "traditional" file like
today. Also not "all" plugins need to be adjusted, just these that care about
build vs consumer pom...
exactly so if you do you are no more compatible with the chain you describe
earlier since the right pom will not be consumed downside so we need to be
vigilant and see if it is an issue to break all the existing ecosystem or if we
don't care plugins using this new (to be defined) API will not be compatible
with existing plugins.
> Add a consumerPomFile to the MavenProject
> -----------------------------------------
>
> Key: MNG-8072
> URL: https://issues.apache.org/jira/browse/MNG-8072
> Project: Maven
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
>
> Currently there is some vague definition of a "build pom" versus a "consumer
> pom":
> * https://maven.apache.org/studies/consumer-pom/
> * https://cwiki.apache.org/confluence/display/MAVEN/Build+vs+Consumer+POM
> there are also some plugins around to work with this e.g.
> *
> https://tycho.eclipseprojects.io/doc/latest/tycho-packaging-plugin/update-consumer-pom-mojo.html
> * https://www.mojohaus.org/flatten-maven-plugin/plugin-info.html
> but there are some issues:
> # Maven makes some assumptions about its "file", e.g setting the file changes
> the basedir
> # Even though there is a setPomFile method that do not change the basedir
> e.g. a parent ref by default would be broken
> # once we change the file, there is a mismatch between the pom on disk and
> the model
> # it is not possible for a plugin to know the original file and the consumer
> file, e.g. if I want to deploy the original file e.g. with classifier
> "pom-build"
> # because of this usually "consumer pom plugins" generate the the new pom to
> a new file in the project root, where it actually not belongs to and leaves
> the file even after mvn clean if no special actions are taken.
> I therefore like to suggest to enhance the MavenProject with one more method
> set/getConsumerPom that fills this gap, then plugins working on the consumer
> pom can set the file there and e.g.
> https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html can
> look there first, or even have an option to deploy both poms automatically if
> they differ.
> Of course this will be nothing happen right now but looks like something that
> can become useful over time and maybe fully adapted in Maven4.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)