[ 
https://issues.apache.org/jira/browse/MNG-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825017#comment-17825017
 ] 

ASF GitHub Bot commented on MNG-8072:
-------------------------------------

rmannibucau commented on PR #1437:
URL: https://github.com/apache/maven/pull/1437#issuecomment-1987163422

   1. for me it is the promise whatever great you do you will not be able to 
use it so "-1" (dont see it as a blocker more as a "you can but dont cry 
later") to work on anything not on master
   2. think it is thinking wrong, consumer pom should be automatically provided 
by the transformation of the transformed pom which guarantee the v4.0.0 compat 
- if it is incremental we loose that. So I think we should work on the native 
model then let the consumer pom be automatically handled
   3. +1




> Add a consumerPomFile to the MavenProject
> -----------------------------------------
>
>                 Key: MNG-8072
>                 URL: https://issues.apache.org/jira/browse/MNG-8072
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> Currently there is some vague definition of a "build pom" versus a "consumer 
> pom":
> * https://maven.apache.org/studies/consumer-pom/
> * https://cwiki.apache.org/confluence/display/MAVEN/Build+vs+Consumer+POM
> there are also some plugins around to work with this e.g.
> * 
> https://tycho.eclipseprojects.io/doc/latest/tycho-packaging-plugin/update-consumer-pom-mojo.html
> * https://www.mojohaus.org/flatten-maven-plugin/plugin-info.html
> but there are some issues:
> # Maven makes some assumptions about its "file", e.g setting the file changes 
> the basedir
> # Even though there is a setPomFile method that do not change the basedir 
> e.g. a parent ref by default would be broken
> # once we change the file, there is a mismatch between the pom on disk and 
> the model
> # it is not possible for a plugin to know the original file and the consumer 
> file, e.g. if I want to deploy the original file e.g. with classifier 
> "pom-build"
> # because of this usually "consumer pom plugins" generate the the new pom to 
> a new file in the project root, where it actually not belongs to and leaves 
> the file even after mvn clean if no special actions are taken.
> I therefore like to suggest to enhance the MavenProject with one more method 
> set/getConsumerPom that fills this gap, then plugins working on the consumer 
> pom can set the file there and e.g. 
> https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html can 
> look there first, or even have an option to deploy both poms automatically if 
> they differ.
> Of course this will be nothing happen right now but looks like something that 
> can become useful over time and maybe fully adapted in Maven4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to