[ 
https://issues.apache.org/jira/browse/MNG-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825020#comment-17825020
 ] 

ASF GitHub Bot commented on MNG-8072:
-------------------------------------

laeubi commented on PR #1437:
URL: https://github.com/apache/maven/pull/1437#issuecomment-1987166631

   1. You should not assume maven-core(-plugins) inability to adapt to never 
features to everyone, e.g. Tycho always uses latest maven and latest features
   2. "by default" Maven can't know what is desired for a consumer pom, and 
different users have different demands. It might can do some additional 
transformations (e.g. map 'new' constructs > 'old' constructs) but for example 
the initial model for Tycho is almost empty, then we will it dynamically of 
course not reflected in file as we don't want to dirty the build files of the 
user, what even maybe not exits at all as it is a pomless module... then 
tycho-update-consumer-pom performs some transformation (e.g. mapping p2 > real 
maven coordinates) and writes a new file, I can't see how maven could ever 
handle this automatically given that
   3. where current solution has undesired side-effect and only looks at 
`project.getFile()` ....




> Add a consumerPomFile to the MavenProject
> -----------------------------------------
>
>                 Key: MNG-8072
>                 URL: https://issues.apache.org/jira/browse/MNG-8072
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> Currently there is some vague definition of a "build pom" versus a "consumer 
> pom":
> * https://maven.apache.org/studies/consumer-pom/
> * https://cwiki.apache.org/confluence/display/MAVEN/Build+vs+Consumer+POM
> there are also some plugins around to work with this e.g.
> * 
> https://tycho.eclipseprojects.io/doc/latest/tycho-packaging-plugin/update-consumer-pom-mojo.html
> * https://www.mojohaus.org/flatten-maven-plugin/plugin-info.html
> but there are some issues:
> # Maven makes some assumptions about its "file", e.g setting the file changes 
> the basedir
> # Even though there is a setPomFile method that do not change the basedir 
> e.g. a parent ref by default would be broken
> # once we change the file, there is a mismatch between the pom on disk and 
> the model
> # it is not possible for a plugin to know the original file and the consumer 
> file, e.g. if I want to deploy the original file e.g. with classifier 
> "pom-build"
> # because of this usually "consumer pom plugins" generate the the new pom to 
> a new file in the project root, where it actually not belongs to and leaves 
> the file even after mvn clean if no special actions are taken.
> I therefore like to suggest to enhance the MavenProject with one more method 
> set/getConsumerPom that fills this gap, then plugins working on the consumer 
> pom can set the file there and e.g. 
> https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html can 
> look there first, or even have an option to deploy both poms automatically if 
> they differ.
> Of course this will be nothing happen right now but looks like something that 
> can become useful over time and maybe fully adapted in Maven4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to