[ 
https://issues.apache.org/jira/browse/MNG-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825013#comment-17825013
 ] 

ASF GitHub Bot commented on MNG-8072:
-------------------------------------

laeubi commented on PR #1437:
URL: https://github.com/apache/maven/pull/1437#issuecomment-1987153495

   > but my point was more to not add a new consumerPom file which is not about 
consumer pom and just yet another attached artifact - we already have this 
feature without this new method.
   
   But you can't modify an artifact (or should not) + there is no way for a 
plugin to participate as part of the mojo-execution with an extension but this 
is required as usually you want ti to be configured and you want to control 
order, e.g. usually one want maybe first tycho inject some things, then clear 
others with flatten-maven, maybe then finally something what maven do by 
default....
   
   > Waiting your PR on all existing plugins using getFile() ;). Switching a 
method is not that trivial there. For example you break flatten plugin.
   
   It won't break anything ... plugins not supporting this will simply never 
set this and then getConsumerPom() will return the "traditional" file like 
today.




> Add a consumerPomFile to the MavenProject
> -----------------------------------------
>
>                 Key: MNG-8072
>                 URL: https://issues.apache.org/jira/browse/MNG-8072
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> Currently there is some vague definition of a "build pom" versus a "consumer 
> pom":
> * https://maven.apache.org/studies/consumer-pom/
> * https://cwiki.apache.org/confluence/display/MAVEN/Build+vs+Consumer+POM
> there are also some plugins around to work with this e.g.
> * 
> https://tycho.eclipseprojects.io/doc/latest/tycho-packaging-plugin/update-consumer-pom-mojo.html
> * https://www.mojohaus.org/flatten-maven-plugin/plugin-info.html
> but there are some issues:
> # Maven makes some assumptions about its "file", e.g setting the file changes 
> the basedir
> # Even though there is a setPomFile method that do not change the basedir 
> e.g. a parent ref by default would be broken
> # once we change the file, there is a mismatch between the pom on disk and 
> the model
> # it is not possible for a plugin to know the original file and the consumer 
> file, e.g. if I want to deploy the original file e.g. with classifier 
> "pom-build"
> # because of this usually "consumer pom plugins" generate the the new pom to 
> a new file in the project root, where it actually not belongs to and leaves 
> the file even after mvn clean if no special actions are taken.
> I therefore like to suggest to enhance the MavenProject with one more method 
> set/getConsumerPom that fills this gap, then plugins working on the consumer 
> pom can set the file there and e.g. 
> https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html can 
> look there first, or even have an option to deploy both poms automatically if 
> they differ.
> Of course this will be nothing happen right now but looks like something that 
> can become useful over time and maybe fully adapted in Maven4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to