[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808234#comment-17808234
]
ASF GitHub Bot commented on MNG-8006:
-------------------------------------
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457519372
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##########
@@ -133,4 +134,10 @@ default String getId() {
@Nonnull
List<RemoteRepository> getRemotePluginRepositories();
+
+ /**
+ * Returns the effective project properties.
+ */
+ @Nonnull
+ Map<String, String> getProperties();
Review Comment:
I don't think introducing a mutable aspect here is a good idea. This map
should be made immutable imho.
Modifying project properties can be done using the `ProjectManager`.
> Provide a SPI so that extension can interact with user properties at session
> creation time
> ------------------------------------------------------------------------------------------
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
> Reporter: Guillaume Nodet
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
