[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808582#comment-17808582
]
ASF GitHub Bot commented on MNG-8006:
-------------------------------------
cstamas commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1458691354
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##########
@@ -55,23 +56,32 @@ public interface Session {
SessionData getData();
/**
- * Gets the user properties to use for interpolation. The user properties
have been configured directly by the user,
- * e.g. via the {@code -Dkey=value} parameter on the command line.
+ * Returns immutable user properties to use for interpolation. The user
properties have been configured directly
+ * by the user, e.g. via the {@code -Dkey=value} parameter on the command
line.
*
* @return the user properties, never {@code null}
*/
@Nonnull
Map<String, String> getUserProperties();
/**
- * Gets the system properties to use for interpolation. The system
properties are collected from the runtime
- * environment such as {@link System#getProperties()} and environment
variables.
+ * Returns immutable system properties to use for interpolation. The
system properties are collected from the
+ * runtime environment such as {@link System#getProperties()} and
environment variables.
*
* @return the system properties, never {@code null}
*/
@Nonnull
Map<String, String> getSystemProperties();
+ /**
+ * Each invocation computes a new map of effective properties. To be used
in interpolation.
Review Comment:
Done
> Provide a SPI so that extension can interact with user properties at session
> creation time
> ------------------------------------------------------------------------------------------
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
> Reporter: Guillaume Nodet
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
