[
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808238#comment-17808238
]
ASF GitHub Bot commented on MNG-8006:
-------------------------------------
gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457521290
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##########
@@ -73,15 +74,12 @@ public interface Session {
Map<String, String> getSystemProperties();
/**
- * Gets the immutable effective properties to use for interpolation. The
effective properties are collected from
- * {@link #getSystemProperties()} and {@link #getUserProperties()} in this
order, and more.
- * <p>
- * These properties are "effective" in a way they are built obeying all
"user overrides" and others.
+ * Gets the effective properties to use for interpolation.
*
- * @return the config properties, never {@code null}
+ * @return the effective properties, never {@code null}
Review Comment:
Add `@see Properties#effectiveProperties(Project)` ?
> Provide a SPI so that extension can interact with user properties at session
> creation time
> ------------------------------------------------------------------------------------------
>
> Key: MNG-8006
> URL: https://issues.apache.org/jira/browse/MNG-8006
> Project: Maven
> Issue Type: New Feature
> Components: API
> Reporter: Guillaume Nodet
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
