gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457519372


##########
api/maven-api-core/src/main/java/org/apache/maven/api/Project.java:
##########
@@ -133,4 +134,10 @@ default String getId() {
 
     @Nonnull
     List<RemoteRepository> getRemotePluginRepositories();
+
+    /**
+     * Returns the effective project properties.
+     */
+    @Nonnull
+    Map<String, String> getProperties();

Review Comment:
   I don't think introducing a mutable aspect here is a good idea.  This map 
should be made immutable imho.
   Modifying project properties can be done using the `ProjectManager`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to