[ 
https://issues.apache.org/jira/browse/MNG-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808246#comment-17808246
 ] 

ASF GitHub Bot commented on MNG-8006:
-------------------------------------

cstamas commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1457526016


##########
api/maven-api-core/src/main/java/org/apache/maven/api/services/Properties.java:
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import java.util.Map;
+
+import org.apache.maven.api.*;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+import org.apache.maven.api.annotations.Nullable;
+
+/**
+ * @since 4.0.0
+ */
+@Experimental
+public interface Properties extends Service {
+
+    /**
+     * Creates a {@link org.apache.maven.api.Project} from a POM file.

Review Comment:
   you did not refresh? You create comments that are outdated from start 
:smile: 





> Provide a SPI so that extension can interact with user properties at session 
> creation time
> ------------------------------------------------------------------------------------------
>
>                 Key: MNG-8006
>                 URL: https://issues.apache.org/jira/browse/MNG-8006
>             Project: Maven
>          Issue Type: New Feature
>          Components: API
>            Reporter: Guillaume Nodet
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> To cleanly support  
> [os-maven-plugin|https://github.com/trustin/os-maven-plugin/]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to