jorsol commented on code in PR #181:
URL:
https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404827601
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1400,10 +1406,11 @@ protected int getRequestThreadCount() {
return session.getRequest().getDegreeOfConcurrency();
}
- protected Date getBuildStartTime() {
- MavenExecutionRequest request = session.getRequest();
- Date buildStartTime = request == null ? new Date() :
request.getStartTime();
- return buildStartTime == null ? new Date() : buildStartTime;
+ private Optional<Instant> getBuildStartTime() {
Review Comment:
Actually there are many false-positive results, searching by
https://github.com/search?q=%22import+org.apache.maven.plugin.compiler.AbstractCompilerMojo%22&type=code
gives a closer look of what is actually using this class, there are a few
results, so yes, there are external consumers.
I will revert them to protected since it actually doesn't make a difference
for what this PR is fixing.
BTW, forever is a long time, I expect this plugin and others to be rewritten
someday and drop the legacy baggage ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
