olamy commented on code in PR #181:
URL:
https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404714195
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1156,6 +1151,16 @@ public void execute() throws MojoExecutionException,
CompilationFailureException
incrementalBuildHelper.beforeRebuildExecution(incrementalBuildHelperRequest);
+ // Cleanup the generated sources directory
+ if (getGeneratedSourcesDirectory() != null) {
Review Comment:
Why cleaning this directory? I don't understand the reason. Can you please
explain?
reading the change as it it looks this will remove the generated-sources
added via the phase `generate-sources` or any phase before compile.
Maybe I read the change in a wrong way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
