olamy commented on code in PR #181:
URL:
https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404715210
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1539,36 +1546,41 @@ private static List<String>
removeEmptyCompileSourceRoots(List<String> compileSo
* generated classes and if we got a file which is >= the build-started
timestamp, then we caught a file which
* got changed during this build.
*
- * @return <code>true</code> if at least one single dependency has changed.
+ * @return {@code true} if at least one single dependency has changed.
*/
- protected boolean isDependencyChanged() {
- if (session == null) {
+ private boolean isDependencyChanged() {
Review Comment:
breaking backward compat protected -> private
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1400,10 +1406,11 @@ protected int getRequestThreadCount() {
return session.getRequest().getDegreeOfConcurrency();
}
- protected Date getBuildStartTime() {
- MavenExecutionRequest request = session.getRequest();
- Date buildStartTime = request == null ? new Date() :
request.getStartTime();
- return buildStartTime == null ? new Date() : buildStartTime;
+ private Optional<Instant> getBuildStartTime() {
Review Comment:
uhm you're changing a protected method. this is breaking any backward compat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
