jorsol commented on code in PR #181:
URL:
https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404812699
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1400,10 +1406,11 @@ protected int getRequestThreadCount() {
return session.getRequest().getDegreeOfConcurrency();
}
- protected Date getBuildStartTime() {
- MavenExecutionRequest request = session.getRequest();
- Date buildStartTime = request == null ? new Date() :
request.getStartTime();
- return buildStartTime == null ? new Date() : buildStartTime;
+ private Optional<Instant> getBuildStartTime() {
Review Comment:
I might be missing something, but I don't expect that anyone extend from
AbstractCompilerMojo externally, I have never seen maven plugins as public APIs
that can be extended, in other words protected works for subclasses that are on
a different package, so this should not break anything.
The only consumer is m-compiler-p itself, and even if this method is used in
a subclass it should be package-protected (no modifier) since the subclasses
CompilerMojo and TestCompilerMojo are on the same package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
