[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540820#comment-17540820
]
ASF GitHub Bot commented on SCM-981:
------------------------------------
nielsbasjes commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r879140561
##########
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##########
@@ -112,14 +114,19 @@ protected List<String> getScmFileNames()
public abstract void initRepo()
throws Exception;
+ private static final Logger LOG = LoggerFactory.getLogger(
ScmTckTestCase.class );
+
@Before
public void checkScmPresence()
{
String scmProviderCommand = getScmProviderCommand();
if ( scmProviderCommand != null )
{
+ LOG.warn( "Checking for required SCM command \"{}\" --> {}",
+ scmProviderCommand, ScmTestCase.isSystemCmd(
scmProviderCommand ) );
assumeTrue( "Skipping tests because the required command " +
scmProviderCommand + " is not available.",
ScmTestCase.isSystemCmd( scmProviderCommand ) );
+ LOG.warn( "Required SCM command \"{}\" exists.",
scmProviderCommand );
Review Comment:
It works now, on MacOS on Github I see:
```
2022-05-23T08:00:42.9665730Z [INFO]
2022-05-23T08:00:42.9767310Z [INFO]
-------------------------------------------------------
2022-05-23T08:00:42.9868750Z [INFO] T E S T S
2022-05-23T08:00:42.9969860Z [INFO]
-------------------------------------------------------
2022-05-23T08:00:43.2415810Z [INFO] Running
org.apache.maven.scm.provider.hg.repository.HgScmProviderRepositoryTest
2022-05-23T08:00:43.3204390Z [INFO] Tests run: 6, Failures: 0, Errors: 0,
Skipped: 0, Time elapsed: 0.077 s - in
org.apache.maven.scm.provider.hg.repository.HgScmProviderRepositoryTest
2022-05-23T08:00:43.3223180Z [INFO] Running
org.apache.maven.scm.provider.hg.HgUtilsTest
2022-05-23T08:00:43.3792390Z [INFO] Tests run: 2, Failures: 0, Errors: 0,
Skipped: 0, Time elapsed: 0.056 s - in
org.apache.maven.scm.provider.hg.HgUtilsTest
2022-05-23T08:00:43.3820030Z [INFO] Running
org.apache.maven.scm.provider.hg.command.update.HgUpdateCommandTckTest
2022-05-23T08:00:43.4054560Z [WARNING] Tests run: 1, Failures: 0, Errors: 0,
Skipped: 1, Time elapsed: 0.024 s - in
org.apache.maven.scm.provider.hg.command.update.HgUpdateCommandTckTest
2022-05-23T08:00:43.4057710Z [INFO] Running
org.apache.maven.scm.provider.hg.command.changelog.HgChangeLogCommandTckTest
2022-05-23T08:00:43.4130830Z [WARNING] Tests run: 1, Failures: 0, Errors: 0,
Skipped: 1, Time elapsed: 0.006 s - in
org.apache.maven.scm.provider.hg.command.changelog.HgChangeLogCommandTckTest
2022-05-23T08:00:43.4138580Z [INFO] Running
org.apache.maven.scm.provider.hg.command.diff.HgDiffCommandTckTest
2022-05-23T08:00:43.4208220Z [WARNING] Tests run: 1, Failures: 0, Errors: 0,
Skipped: 1, Time elapsed: 0.007 s - in
org.apache.maven.scm.provider.hg.command.diff.HgDiffCommandTckTest
2022-05-23T08:00:43.4224000Z [INFO] Running
org.apache.maven.scm.provider.hg.command.status.HgStatusCommandTckTest
2022-05-23T08:00:43.4280470Z [WARNING] Tests run: 1, Failures: 0, Errors: 0,
Skipped: 1, Time elapsed: 0.006 s - in
org.apache.maven.scm.provider.hg.command.status.HgStatusCommandTckTest
2022-05-23T08:00:43.4287380Z [INFO] Running
org.apache.maven.scm.provider.hg.command.checkout.HgCheckOutCommandTckTest
2022-05-23T08:00:43.4345300Z [WARNING] Tests run: 1, Failures: 0, Errors: 0,
Skipped: 1, Time elapsed: 0.005 s - in
org.apache.maven.scm.provider.hg.command.checkout.HgCheckOutCommandTckTest
2022-05-23T08:00:43.4363420Z [INFO] Running
org.apache.maven.scm.provider.hg.command.blame.HgBlameCommandTckTest
2022-05-23T08:00:43.4419300Z [WARNING] Tests run: 1, Failures: 0, Errors: 0,
Skipped: 1, Time elapsed: 0.006 s - in
org.apache.maven.scm.provider.hg.command.blame.HgBlameCommandTckTest
2022-05-23T08:00:43.4468160Z [INFO] Running
org.apache.maven.scm.provider.hg.command.checkin.HgCheckInCommandTckTest
2022-05-23T08:00:43.4567260Z [WARNING] Tests run: 2, Failures: 0, Errors: 0,
Skipped: 2, Time elapsed: 0.013 s - in
org.apache.maven.scm.provider.hg.command.checkin.HgCheckInCommandTckTest
2022-05-23T08:00:43.4574170Z [INFO] Running
org.apache.maven.scm.provider.hg.command.tag.HgTagCommandTckTest
2022-05-23T08:00:43.4628770Z [WARNING] Tests run: 1, Failures: 0, Errors: 0,
Skipped: 1, Time elapsed: 0.005 s - in
org.apache.maven.scm.provider.hg.command.tag.HgTagCommandTckTest
2022-05-23T08:00:44.6834330Z [INFO]
2022-05-23T08:00:44.6834780Z [INFO] Results:
2022-05-23T08:00:44.6837080Z [INFO]
2022-05-23T08:00:44.6837810Z [WARNING] Tests run: 17, Failures: 0, Errors:
0, Skipped: 9
```
> Several integration tests are never run and fail if you do.
> -----------------------------------------------------------
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
> Reporter: Niels Basjes
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0-M2
>
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
