[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540692#comment-17540692
]
ASF GitHub Bot commented on SCM-981:
------------------------------------
michael-o commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878926275
##########
maven-scm-providers/maven-scm-provider-hg/src/test/java/org/apache/maven/scm/provider/hg/HgRepoUtils.java:
##########
@@ -35,9 +35,11 @@
*
* @author <a href="mailto:thurner.rup...@ymono.net";>thurner rupert</a>
*/
-public class HgRepoUtils
+public abstract class HgRepoUtils
Review Comment:
Why? This class even extends `ScmTestCase` for whatsoever reason and has no
descendants.
> Several integration tests are never run and fail if you do.
> -----------------------------------------------------------
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
> Reporter: Niels Basjes
> Assignee: Michael Osipov
> Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
