[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540808#comment-17540808
]
ASF GitHub Bot commented on SCM-981:
------------------------------------
nielsbasjes commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r879117368
##########
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##########
@@ -112,14 +114,19 @@ protected List<String> getScmFileNames()
public abstract void initRepo()
throws Exception;
+ private static final Logger LOG = LoggerFactory.getLogger(
ScmTckTestCase.class );
+
@Before
public void checkScmPresence()
{
String scmProviderCommand = getScmProviderCommand();
if ( scmProviderCommand != null )
{
+ LOG.warn( "Checking for required SCM command \"{}\" --> {}",
+ scmProviderCommand, ScmTestCase.isSystemCmd(
scmProviderCommand ) );
assumeTrue( "Skipping tests because the required command " +
scmProviderCommand + " is not available.",
ScmTestCase.isSystemCmd( scmProviderCommand ) );
+ LOG.warn( "Required SCM command \"{}\" exists.",
scmProviderCommand );
Review Comment:
Found it. Multiple `@Before` and no ordering guarantee among these.
> Several integration tests are never run and fail if you do.
> -----------------------------------------------------------
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
> Reporter: Niels Basjes
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0-M2
>
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
