[ 
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540400#comment-17540400
 ] 

ASF GitHub Bot commented on SCM-979:
------------------------------------

cstamas commented on code in PR #143:
URL: https://github.com/apache/maven-scm/pull/143#discussion_r878674802


##########
maven-scm-test/pom.xml:
##########
@@ -60,7 +60,6 @@
       <groupId>com.google.inject</groupId>
       <artifactId>guice</artifactId>
       <classifier>no_aop</classifier>
-      <scope>runtime</scope>

Review Comment:
   OTOH, this module is ONLY in test scope of other modules, so guice is 
compile to this module, while is test + runtime for  others





> Replace Plexus Container Default with Sisu Plexus Shim, Java8
> -------------------------------------------------------------
>
>                 Key: SCM-979
>                 URL: https://issues.apache.org/jira/browse/SCM-979
>             Project: Maven SCM
>          Issue Type: Task
>            Reporter: Michael Osipov
>            Assignee: Tamás Cservenák
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> Changes:
>  * make project Java8
>  * update dependencies accordingly
>  * remove any uses of deprecated Plexus APIs
>  * replace plexus-container-default with plexus-shim
>  * replace/drop PlexusLogger/ScmLogger and use SLF4J API
>  * replace use of Junit3 PlexusTestCase with Junit4 (make possible use of 
> Assume)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to