[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim, Java8

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540391#comment-17540391
 ] 

ASF GitHub Bot commented on SCM-979:
------------------------------------

cstamas commented on code in PR #143:
URL: https://github.com/apache/maven-scm/pull/143#discussion_r878674139


##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/mkdir/SvnMkdirCommandTest.java:
##########
@@ -39,7 +42,7 @@
 
     String messageFileString;
 
-    protected void setUp()
+    public void setUp()

Review Comment:
   fixed



##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/changelog/SvnChangeLogConsumerTest.java:
##########
@@ -39,19 +40,23 @@
 import java.util.TimeZone;
 import java.util.concurrent.atomic.AtomicInteger;
 
+import static junit.framework.TestCase.assertTrue;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
 /**
  * @author <a href="mailto:eveni...@apache.org";>Emmanuel Venisse</a>
  *
  */
 public class SvnChangeLogConsumerTest
-    extends PlexusTestCase
+        extends ScmTestCase
 {
     Logger logger = LoggerFactory.getLogger( getClass() );
 
     SvnChangeLogConsumer consumer;
 
 
-    protected void setUp()
+    public void setUp()

Review Comment:
   fixed





> Replace Plexus Container Default with Sisu Plexus Shim, Java8
> -------------------------------------------------------------
>
>                 Key: SCM-979
>                 URL: https://issues.apache.org/jira/browse/SCM-979
>             Project: Maven SCM
>          Issue Type: Task
>            Reporter: Michael Osipov
>            Assignee: Tamás Cservenák
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> Changes:
>  * make project Java8
>  * update dependencies accordingly
>  * remove any uses of deprecated Plexus APIs
>  * replace plexus-container-default with plexus-shim
>  * replace/drop PlexusLogger/ScmLogger and use SLF4J API
>  * replace use of Junit3 PlexusTestCase with Junit4 (make possible use of 
> Assume)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)