[ 
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540469#comment-17540469
 ] 

ASF GitHub Bot commented on SCM-979:
------------------------------------

michael-o commented on code in PR #141:
URL: https://github.com/apache/maven-scm/pull/141#discussion_r878738178


##########
maven-scm-api/src/main/java/org/apache/maven/scm/log/ScmLogDispatcher.java:
##########
@@ -30,14 +30,15 @@
 public class ScmLogDispatcher
     implements ScmLogger
 {
-    private List<ScmLogger> listeners = new ArrayList<ScmLogger>();
+    private final List<ScmLogger> listeners = new CopyOnWriteArrayList<>();

Review Comment:
   Why do we need this COW list?





> Replace Plexus Container Default with Sisu Plexus Shim, Java8
> -------------------------------------------------------------
>
>                 Key: SCM-979
>                 URL: https://issues.apache.org/jira/browse/SCM-979
>             Project: Maven SCM
>          Issue Type: Task
>            Reporter: Michael Osipov
>            Assignee: Tamás Cservenák
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> Changes:
>  * make project Java8
>  * update dependencies accordingly
>  * remove any uses of deprecated Plexus APIs
>  * replace plexus-container-default with plexus-shim
>  * replace/drop PlexusLogger/ScmLogger and use SLF4J API
>  * replace use of Junit3 PlexusTestCase with Junit4 (make possible use of 
> Assume)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to