[ https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540392#comment-17540392 ]
ASF GitHub Bot commented on SCM-979: ------------------------------------ cstamas commented on code in PR #143: URL: https://github.com/apache/maven-scm/pull/143#discussion_r878674173 ########## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommandCommitterAuthorTckTest.java: ########## @@ -63,7 +69,7 @@ protected void setUp() } @Override - protected void tearDown() + public void tearDown() Review Comment: fixed ########## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommandCommitterAuthorTckTest.java: ########## @@ -54,7 +60,7 @@ { @Override - protected void setUp() + public void setUp() Review Comment: fixed > Replace Plexus Container Default with Sisu Plexus Shim, Java8 > ------------------------------------------------------------- > > Key: SCM-979 > URL: https://issues.apache.org/jira/browse/SCM-979 > Project: Maven SCM > Issue Type: Task > Reporter: Michael Osipov > Assignee: Tamás Cservenák > Priority: Major > Fix For: 2.0.0-M2 > > > Changes: > * make project Java8 > * update dependencies accordingly > * remove any uses of deprecated Plexus APIs > * replace plexus-container-default with plexus-shim > * replace/drop PlexusLogger/ScmLogger and use SLF4J API > * replace use of Junit3 PlexusTestCase with Junit4 (make possible use of > Assume) -- This message was sent by Atlassian Jira (v8.20.7#820007)