[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim, Java8

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540390#comment-17540390
 ] 

ASF GitHub Bot commented on SCM-979:
------------------------------------

cstamas commented on code in PR #143:
URL: https://github.com/apache/maven-scm/pull/143#discussion_r878674117


##########
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##########
@@ -98,14 +101,14 @@ public abstract void initRepo()
     /**
      * {@inheritDoc}
      */
-    protected void setUp()
+    public void setUp()

Review Comment:
   fixed



##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/mkdir/SvnMkdirCommandTest.java:
##########
@@ -56,21 +59,23 @@ protected void setUp()
         messageFileString = "--file " + path + " --encoding UTF-8";
     }
 
-    protected void tearDown()
+    public void tearDown()

Review Comment:
   fixed





> Replace Plexus Container Default with Sisu Plexus Shim, Java8
> -------------------------------------------------------------
>
>                 Key: SCM-979
>                 URL: https://issues.apache.org/jira/browse/SCM-979
>             Project: Maven SCM
>          Issue Type: Task
>            Reporter: Michael Osipov
>            Assignee: Tamás Cservenák
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> Changes:
>  * make project Java8
>  * update dependencies accordingly
>  * remove any uses of deprecated Plexus APIs
>  * replace plexus-container-default with plexus-shim
>  * replace/drop PlexusLogger/ScmLogger and use SLF4J API
>  * replace use of Junit3 PlexusTestCase with Junit4 (make possible use of 
> Assume)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)