[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim, Java8

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540159#comment-17540159
 ] 

ASF GitHub Bot commented on SCM-979:
------------------------------------

slawekjaranowski commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878243579


##########
maven-scm-api/src/main/java/org/apache/maven/scm/command/AbstractCommand.java:
##########
@@ -35,7 +35,7 @@
 public abstract class AbstractCommand
     implements Command
 {
-    private ScmLogger logger = new Slf4jScmLogger( getClass() );
+    protected Logger logger = LoggerFactory.getLogger( getClass() );

Review Comment:
   better is private and to have separate logger for each class, in this way 
logger name will be inconsistent with usage.





> Replace Plexus Container Default with Sisu Plexus Shim, Java8
> -------------------------------------------------------------
>
>                 Key: SCM-979
>                 URL: https://issues.apache.org/jira/browse/SCM-979
>             Project: Maven SCM
>          Issue Type: Task
>            Reporter: Michael Osipov
>            Assignee: Tamás Cservenák
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> Changes:
>  * make project Java8
>  * update dependencies accordingly
>  * remove any uses of deprecated Plexus APIs
>  * replace plexus-container-default with plexus-shim



--
This message was sent by Atlassian Jira
(v8.20.7#820007)