ajohnstonTE commented on a change in pull request #267: [SUREFIRE-1741] JUnit5:
Detect failed containers
URL: https://github.com/apache/maven-surefire/pull/267#discussion_r370925040
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##########
@@ -185,6 +188,13 @@ private SimpleReportEntry createReportEntry(
TestIdentifier testIdentifier,
stw, elapsedTime, reason, systemProperties );
}
+ private boolean isFailedContainer( TestIdentifier testIdentifier,
+ TestExecutionResult testExecutionResult )
+ {
+ return testIdentifier.isContainer() && testExecutionResult != null
Review comment:
I think I see the confusion. I have some changes to how the logic is applied
to address some other cases. Those changes also end up reducing the scope of
that null check to only the appropriate places. I'm currently waiting for it to
do a full build, so I'll probably push them a while later today. Once that's
done (assuming it passes), I'll get started on the IT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
