ajohnstonTE commented on a change in pull request #267: [SUREFIRE-1741] JUnit5:
Detect failed containers
URL: https://github.com/apache/maven-surefire/pull/267#discussion_r372834207
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##########
@@ -185,6 +188,13 @@ private SimpleReportEntry createReportEntry(
TestIdentifier testIdentifier,
stw, elapsedTime, reason, systemProperties );
}
+ private boolean isFailedContainer( TestIdentifier testIdentifier,
+ TestExecutionResult testExecutionResult )
+ {
+ return testIdentifier.isContainer() && testExecutionResult != null
Review comment:
The PR that you closed in favor of this one, #257, the owner had gotten
started on some additional IT's for their own issue:
https://github.com/apache/maven-surefire/compare/master...t-8ch:e6c3c4fef38ee6a5e5352bec447e047713b7cd0b
Should I copy those IT's into this? I'm not super familiar with
`@TestFactory` or `@TestTemplate`, and I'm not sure what the state of those
IT's are, but would that be preferable as a means to also resolve that other
issue? I did a quick local check after my first couple commits to see if this
addresses that issue, and if I remember correctly, it does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
