Tibor17 commented on a change in pull request #267: [SUREFIRE-1741] JUnit5:
Detect failed containers
URL: https://github.com/apache/maven-surefire/pull/267#discussion_r372693975
##########
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/RunListenerAdapterTest.java
##########
@@ -425,7 +425,7 @@ public void notifiedOfContainerFailure()
throws Exception
{
adapter.executionFinished( newContainerIdentifier(), failed( new
RuntimeException() ) );
- verify( listener ).testFailed( any() );
+ verify( listener ).testError( any() );
Review comment:
I see you crated the test methods in the commit `136f79ee`. So it's your's,
just fine when you modify your's!
Feel free to rename `!isTest` to `isClass`. I don't have a problem with that
due to you have extended the branching with `else if (
testIdentifier.isContainer() )`. If the new argument with `isClass` is fully
logical and right to do, then use it of course here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
