ajohnstonTE commented on a change in pull request #267: [SUREFIRE-1741] JUnit5:
Detect failed containers
URL: https://github.com/apache/maven-surefire/pull/267#discussion_r372828613
##########
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/RunListenerAdapterTest.java
##########
@@ -425,7 +425,7 @@ public void notifiedOfContainerFailure()
throws Exception
{
adapter.executionFinished( newContainerIdentifier(), failed( new
RuntimeException() ) );
- verify( listener ).testFailed( any() );
+ verify( listener ).testError( any() );
Review comment:
Ok, this whole case has been updated to reflect the changes I was
suggesting. Test failures and errors should be properly respected for every
`FAILURE` now (previously a `RuntimeException` would not have been considered a
test error for `@BeforeAll`, for example, it would instead be treated as a
failure).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
