costin commented on code in PR #16623:
URL: https://github.com/apache/lucene/pull/16623#discussion_r4197750970
##########
lucene/core/src/java/org/apache/lucene/util/LiveDocs.java:
##########
@@ -82,4 +82,13 @@ public interface LiveDocs extends Bits {
* @return the number of deleted documents in this segment
*/
int deletedCount();
+
+ /**
+ * Materializes this LiveDocs as a {@link FixedBitSet} where set bits
represent live documents.
+ *
+ * <p>Used by {@link FixedBitSet#copyOf(Bits)} to avoid the per-bit generic
loop.
+ *
+ * @return a new {@link FixedBitSet} with set bits for live documents
+ */
+ FixedBitSet toFixedBitSet();
Review Comment:
Good call. It was left over from my experiments; I removed toFixedBitSet
from LiveDocs. copyOf now fills the bit set and calls applyMask, so dense uses
andRange and sparse uses andNotRange, without a new API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
