costin opened a new pull request, #16623: URL: https://github.com/apache/lucene/pull/16623
After LiveDocs interface was introduced in #15413, FixedBitSet.copyOf fell to per-bit loop execution instead of using the specialized fast paths in Dense/SparseLiveDocs. This PR addresses that by introducing a toFixedBitSet() method on LiveDocs and a dedicated check in copyOf. Since there are only two implementations of LiveDocs, both final, the dispatch is bimorphic and inlineable. copyOf bytecode goes from 90 to 113 bytes, well under the 325-byte FreqInlineSize threshold. I've included a JMH benchmark and an end-to-end benchmark that measures the impact on SoftDeletesDirectoryReaderWrapper. Alternative to #16282 which found the same gap but used a different approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
