rmuir commented on code in PR #16741:
URL: https://github.com/apache/lucene/pull/16741#discussion_r4147311080
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##########
@@ -161,7 +162,7 @@ public void tearDown() throws Exception {
private static Version getLatestPreviousMajorVersion() {
Version lastPrevMajorVersion = null;
for (Version v : getAllCurrentVersions()) {
- if (v.major == Version.MIN_SUPPORTED_MAJOR
+ if (v.major == Version.LATEST.major - 1
Review Comment:
Can we remove the split to simplify the backwards compatibility logic? It
would eliminate my biggest fear looking at these changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
