javanna commented on code in PR #16741:
URL: https://github.com/apache/lucene/pull/16741#discussion_r4146369661
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##########
@@ -161,7 +162,7 @@ public void tearDown() throws Exception {
private static Version getLatestPreviousMajorVersion() {
Version lastPrevMajorVersion = null;
for (Version v : getAllCurrentVersions()) {
- if (v.major == Version.MIN_SUPPORTED_MAJOR
+ if (v.major == Version.LATEST.major - 1
Review Comment:
Most of the changes in this PR enforce the split between min binary
supported version (for read-only support via expert API, no index writer) and
min supported version (full support, with index writer). This one change is the
outlier where we do want to resolve the previous major version for good reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
