ChrisHegarty commented on code in PR #16741:
URL: https://github.com/apache/lucene/pull/16741#discussion_r4142207870
##########
lucene/core/src/java/org/apache/lucene/util/Version.java:
##########
@@ -195,7 +300,25 @@ public final class Version {
*
* @since 11.0.0
*/
- public static final int MIN_SUPPORTED_MAJOR = 10;
+ public static final int MIN_SUPPORTED_MAJOR = 9;
+
+ /**
+ * The minimum major version that can be read via the expert-API read-only
path (e.g. {@code
+ * StandardDirectoryReader.open(commit, minSupportedMajor, executor)} and
{@code
+ * SegmentInfos.readLatestCommit(dir, minSupportedMajor)}).
+ *
+ * <p>This constant is pinned to the previous major at the time its index
zip files and codec
+ * support were collected. It must be set explicitly rather than derived
from {@link
+ * #MIN_SUPPORTED_MAJOR} arithmetically, so that it remains stable when
{@link
+ * #MIN_SUPPORTED_MAJOR} is bumped for a new major release.
+ *
+ * <p><b>When to update:</b> When {@link #MIN_SUPPORTED_MAJOR} is bumped,
set this constant to the
+ * old value of {@link #MIN_SUPPORTED_MAJOR} and add the corresponding index
zip files and codec
+ * support to the backward-codecs module.
+ *
Review Comment:
I'm a little confused by this. If we set MIN_BINARY_SUPPORTED_MAJOR to the
value of MIN_SUPPORTED_MAJOR (9), when MIN_BINARY_SUPPORTED_MAJOR is next
bumped, then it will still be 9. Right? And that's ok (what we expect)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
