javanna commented on code in PR #16741:
URL: https://github.com/apache/lucene/pull/16741#discussion_r4146348216
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestAncientIndicesCompatibility.java:
##########
@@ -199,18 +199,23 @@ public void testUnsupportedOldIndexes() throws Exception {
checker.setInfoStream(new PrintStream(bos, false, UTF_8));
checker.setLevel(CheckIndex.Level.MIN_LEVEL_FOR_INTEGRITY_CHECKS);
CheckIndex.Status indexStatus = checker.checkIndex();
+ // TODO this conditional is no longer exercised.
+ // It would only be needed in the future for versions that can only be
+ // read via expert API (hence their codecs are maintained), but can't be
written into.
+ /*
Review Comment:
I think so, I need to refine this and avoid commenting out the whole block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
