rmuir commented on PR #14939: URL: https://github.com/apache/lucene/pull/14939#issuecomment-3065576724
> Hi you are doing multiple things in this PR. Mainly I don't want the first file in the diff. This one is my main problem. OK, let's just remove that here. Pretend it isn't here. My goal is to ban trappy methods that require specific hardware support. If I can do it with forbidden-apis, then we'll add helpers like we do for fma() for each one of them, and check for the hardware feature in the helper: problem solved. I will dig more into the forbidden apis logic in the gradle. I think it is in java now, so I should be able to solve it with the api jar. If we can't check for the trappy methods with forbidden-apis, then only other idea I have is to fallback to hackier solutions as seen here, it is difficult to "ban methods" from source code perspective: you've gotta deal with types and imports and all the crazy logic you see in this PR. Bytecode approach with forbidden apis is simpler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
