uschindler commented on PR #14939:
URL: https://github.com/apache/lucene/pull/14939#issuecomment-3065423818
Sorry I disagree with this
My strong -1.
The whole code in src/java24 ist solely for vector code so I expe t and
allow vector code everywhere.tgere is no need to mit this on one single file.
VectorUtilSupport is only an implementation class (it is not static!!!!) that
implements the interface from main code.
If you want to separate all code using vector incubator do it in a real
static class. The current code is a mix of static and non static stuff. I agree
to move all code to a single class bit then it needs to be a real static one
without instances. The VectorUtilSupport is just implementation of an
interface. Therefore the other code should not be moved there. What you do is
mixing up different stuff. This is not valid to do.
I will immediately revert any merge of this branch, this is all not needed.
If you want control of vector code then add GitHub requirement to have a review
by yourself.
Static analysis is overkill.
Forbidden-apis is not broken it can't just work in this setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
