rmuir commented on PR #14939: URL: https://github.com/apache/lucene/pull/14939#issuecomment-3065372658
> It is limited to the java24 sourceSet. I think you're hunting ghosts - sorry! You misunderstand the check. it is about checking java24 itself. It is about keeping vector api code contained into single files there, with simple functions, that can be traced in simple ways for analysis. What the memory segment code is doing (inlining its own vector code, instead of factoring that out into a separate static method in PanamaVectorUtils) is a perfect example of bad coding practices. It is no different than containing the unsafeness of FAISS to single file. With vector kernels only in a single file, then all the accesses can be traced and analyzed with simple tools, especially when tools such as forbidden apis aren't working at all on the sources (which would make solving these problems easier). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
