rmuir commented on code in PR #14939: URL: https://github.com/apache/lucene/pull/14939#discussion_r2202626616
########## gradle/validation/ast-grep/rules/vectors.yml: ########## @@ -0,0 +1,38 @@ +# Special policing of vectorization sources to prevent performance traps! +--- +# yaml-language-server: $schema=https://raw.githubusercontent.com/ast-grep/ast-grep/refs/heads/main/schemas/java_rule.json +id: illegal-incubator-usage +language: java +ignores: + # the only place vector api code should sit. + - "**/internal/vectorization/PanamaVector{Constants,UtilSupport}.java" + # TODO: move this vector logic to PanamaVectorUtilSupport! + - "**/internal/vectorization/MemorySegmentPostingDecodingUtil.java" Review Comment: I know you are defensive about the memory segment code, but the vectors logic needs to be encapsulated into static method in the utils class, to make static analysis easier. This way no cross-file analysis is needed and all the kernels are in a single file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
