mikemccand commented on PR #14843: URL: https://github.com/apache/lucene/pull/14843#issuecomment-3052286270
> I am not fully happy with this, so I would have given a -1 for the merge. Now it is too late! I am very busy at moment so I wasn't aber to review the code earlier! Oh, sorry, thanks @uschindler -- I will simply revert and we can iterate some more! This is good feedback, and also applies to the `main` version. But this is all in sandbox :) It's OK to be a little ... sandy! I will revert shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
