kaivalnp opened a new pull request, #14843:
URL: https://github.com/apache/lucene/pull/14843

   ### Description
   
   Backport #14178 to 10.x
   
   ### Summary of changes
   
    - Support for JDK21 via MR-JAR and runtime lookup (similar to other 
Panama-based classes 
[here](https://github.com/apache/lucene/tree/f93a0ed318b528229dee91dbbca98cb6607b24ae/lucene/core/src/java21/org/apache/lucene/internal/vectorization)).
 This was tricky because some functions were renamed from JDK21 
(https://openjdk.org/jeps/442) -> JDK22 (https://openjdk.org/jeps/454, where it 
was finalized) -- I'm using method handles to bind to the correct function at 
runtime
    - Allow native access to the `libfaiss_c.so` shared library from tests, 
enforced by the security manager
    - Change GH action to run on JDK21
    - Misc changes for the lower Java language level + 10.x branch
   
   I also ran the Faiss tests offline with JDK 21, 22, 23, 24 using:
   ```sh
   gradlew -p lucene/sandbox -Dtests.faiss.run=true test --tests 
"org.apache.lucene.sandbox.codecs.faiss.*"
   ```
   ..and they all passed!
   
   ### Diff of relevant files
   
   https://gist.github.com/kaivalnp/77fb274ebd3de22c500396e80bb5df3c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to