uschindler commented on PR #14843:
URL: https://github.com/apache/lucene/pull/14843#issuecomment-3052175123
I am not fully happy with this, so I would have given a -1 for the merge.
Now it is too late! I am very busy at moment so I wasn't aber to review the
code earlier!
IMHO, we should have waited and better release main branch with this as
Lucene 11. I'd suggest (see my talk @ buzzwords) to release Lucene 11 a few
months after the release of Java 25 (e.g., November 2025). We have good
features like this already.
There are also some code issues (like catch Throwable and not rethrowing
RuntimeException|Error unmodified and instead all is wrapped in unspecifid
RuntimeException.... - this is a no-go in Lucene code and also discouraged).
Please add followup PRs and cleanup the exception handling. If you catch
"Throwable" alsways add a `catch (RuntimeException|Error e) { throw e; }`.
In addition, all code triggering the restricted warning should be in a
single class (@rmuir already complained with TODOs).
So my personal opinion: Revert revert revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
