jpountz commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2072465976


##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/Lucene101PostingsReader.java:
##########
@@ -149,9 +150,9 @@ public Lucene101PostingsReader(SegmentReadState state) 
throws IOException {
         IndexFileNames.segmentFileName(
             state.segmentInfo.name, state.segmentSuffix, 
Lucene101PostingsFormat.DOC_EXTENSION);
     try {
-      // Postings have a forward-only access pattern, so pass 
ReadAdvice.NORMAL to perform
-      // readahead.
-      docIn = state.directory.openInput(docName, 
state.context.withReadAdvice(ReadAdvice.NORMAL));
+      docIn =
+          state.directory.openInput(
+              docName, state.context.withHints(FileTypeHint.DATA, 
FileDataHint.POSTINGS));

Review Comment:
   Ohhhh I had assumed until now that `DataAccessHint.SEQUENTIAL` effectively 
meant `ReadAdvice.NORMAL`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to