thecoop commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2068657900
########## lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java: ########## @@ -70,14 +72,15 @@ public static MemorySegmentIndexInput newInstance( MemorySegment[] segments, long length, int chunkSizePower, - boolean confined) { + boolean confined, + Function<IOContext, ReadAdvice> toReadAdvice) { Review Comment: A `Function` representing the mapping keeps the IOContext -> ReadAdvice entirely within `MMapDirectory` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org