benwtrent commented on code in PR #14523:
URL: https://github.com/apache/lucene/pull/14523#discussion_r2050896318
##########
lucene/core/src/java/org/apache/lucene/search/DisjunctionDISIApproximation.java:
##########
@@ -146,7 +146,13 @@ public int advance(int target) throws IOException {
@Override
public void intoBitSet(int upTo, FixedBitSet bitSet, int offset) throws
IOException {
while (leadTop.doc < upTo) {
- leadTop.approximation.intoBitSet(upTo, bitSet, offset);
+ int intoBitSetBase = offset;
+ if (leadTop.approximation.docID() < offset) {
+ intoBitSetBase = leadTop.approximation.advance(offset);
+ }
+ if (intoBitSetBase < upTo) {
+ leadTop.approximation.intoBitSet(upTo, bitSet, intoBitSetBase);
Review Comment:
I am not changing `offset` So, on the next lead (e.g after updateTop()), it
will be the original offset again, which then the iterator currently checking
advances, it will set its valid bits right?
I admit, this whole API and portion of Lucene is very difficult to fully
understand and follow :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
