benwtrent commented on code in PR #14523:
URL: https://github.com/apache/lucene/pull/14523#discussion_r2050933006
##########
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##########
@@ -434,6 +434,9 @@ public void intoBitSet(int upTo, FixedBitSet bitSet, int
offset) throws IOExcept
if (competitiveIterator.docID() < doc) {
Review Comment:
This part is strange. All other `intoBitSet` impls that I can find call the
competitiveIterator to advance to at least `offset`, not to some internal
`doc`. I suppose NumericComparator is unique?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
