gf2121 commented on code in PR #14523: URL: https://github.com/apache/lucene/pull/14523#discussion_r2050892058
########## lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java: ########## @@ -203,7 +203,8 @@ protected final int slowAdvance(int target) throws IOException { * @lucene.internal */ public void intoBitSet(int upTo, FixedBitSet bitSet, int offset) throws IOException { - assert offset <= docID(); + assert offset <= docID() && offset <= upTo Review Comment: I think it is valid to provide offset bigger than offset, it would be a no-op method, but nothing broken? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org