benwtrent opened a new pull request, #14523: URL: https://github.com/apache/lucene/pull/14523
Similar to @ChrisHegarty 's change for the count fix, this will move up the `max` check to before the into bit set. It seems like we could be calling intobitset erroneously on some edge cases. Feels very trappy. Additionally, I added some protection higher up the call stack in the DCBS. We advance the interator, but then call intoBitSet even if we advanced way past the maxWindowSize and we would call it with the base, even if we iterated past the base. It seems prudent to set the base to the current place of the lead iterator and not bother with the call if the current lead iterator position is past the max window. TODO: Some tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
