ChrisHegarty commented on PR #13985: URL: https://github.com/apache/lucene/pull/13985#issuecomment-2493554763
> .. > Took a look, The mismatch between `mergeInstanceCount` and `mergeInstance` is because mergeInstanceCount is being updated in parent and mergeInstance is updated to true during getMergeInstance(). If search is happening during merge there is a good chance that it runs into a scenario where `mergeInstanceCount = 1` but `mergeInstance` is false. > > Considering the test has commit() call and then search, I think its running into the scenario Oh yeah. I get it, and the asserts were too strong. I backed them off a bit. High level, I wanna ensure that we're asserting the right execution model, since the backing memory holding the vector data is shared across merge and search at the same time. I think that this is fine, search may access the memory while still in sequential, but when merge finishes it'll switch back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
