shatejas commented on PR #13985: URL: https://github.com/apache/lucene/pull/13985#issuecomment-2489459115
> The `org.apache.lucene.index.TestConcurrentMergeScheduler.testNoWaitClose` test hits a new assert that I added - sorry. I need to look to see if it is a test issue or more of a design issue with finishMerge. > > ``` > ./gradlew test --tests TestConcurrentMergeScheduler.testNoWaitClose -Dtests.file.encoding=UTF-8 -Dtests.iters=10 > ``` I took a look at the failure. Here is what I found, `mergeInstanceCount` does not decrement if the merge is aborted between `getMergeInstance` and when the merge starts ([ref](https://github.com/apache/lucene/blob/9b5edabf21217699a11ecc8aee7e7d1bf39de4fb/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java#L5258)). In that scenario finishMerge is never called and the readers are closed in the [finally block](https://github.com/apache/lucene/blob/9b5edabf21217699a11ecc8aee7e7d1bf39de4fb/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java#L5474) failing the `assert mergeInstanceCount == 0` in AssertingKnnVectorsReader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
