epotyom commented on PR #13657: URL: https://github.com/apache/lucene/pull/13657#issuecomment-2298104290
> @epotyom > > I've noticed by accident that creating two identical lists of collectors, before and after createWeight, makes regression disappear > > Hmm, that is strange. I would think that `collectors2` in your diff would get optimized away since it's never read from? So I thought maybe that explained why you weren't seeing the regression, but if `collectors1` is the one that gets left you'd think we'd still see a regression since it's before `createWeight`? Exactly, without `collectors2` it is the code with the regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
