epotyom commented on PR #13657: URL: https://github.com/apache/lucene/pull/13657#issuecomment-2290926100
Interesting... Thanks for isolating the change that causes the regression Greg! > impacted tasks are possibly taking the `leafSlices.length == 0` condition branch and avoiding the need to create the collectors list at all? I don't think it is that - if I understand correctly `leafSlices.length == 0` only if there are no segments at all - which shouldn't be the case for benchmark tests we are running. Just in case I added a commit on top of this PR to never create the ArrayList for collectors if the length is zero: https://github.com/apache/lucene/commit/e30b76d77926d5f68d70f8b1d3b7129a73b76942 , and it also shows regression: ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value HighTerm 525.44 (3.5%) 441.68 (3.7%) -15.9% ( -22% - -9%) 0.000 HighSloppyPhrase 33.23 (2.7%) 28.13 (1.4%) -15.3% ( -18% - -11%) 0.000 MedTerm 479.40 (4.6%) 410.71 (4.4%) -14.3% ( -22% - -5%) 0.000 LowTerm 433.49 (3.1%) 387.45 (3.1%) -10.6% ( -16% - -4%) 0.000 BrowseMonthTaxoFacets 1.84 (9.0%) 1.70 (8.8%) -7.9% ( -23% - 10%) 0.160 BrowseRandomLabelTaxoFacets 1.37 (12.4%) 1.26 (0.5%) -7.6% ( -18% - 6%) 0.174 HighSpanNear 31.21 (1.7%) 28.97 (2.8%) -7.2% ( -11% - -2%) 0.000 ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
