gsmiller commented on PR #13657:
URL: https://github.com/apache/lucene/pull/13657#issuecomment-2291353795

   I got an even tighter isolation on the regressing change but still can't 
understand why it could be happening. It seems to have to do with 
whether-or-not the collectors list gets created before or after calling 
`createWeight`. So this order _does not_ cause any regression:
   ```
       final Weight weight = createWeight(query, firstCollector.scoreMode(), 1);
       final List<C> collectors = new ArrayList<>(leafSlices.length);
   ```
   
   While this does:
   ```
       final List<C> collectors = new ArrayList<>(leafSlices.length);
       final Weight weight = createWeight(query, firstCollector.scoreMode(), 1);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to